SOLVED Pull request?
-
-
- Eoin
- Hero Rocketeer
- Posts: 424
- Thanks: 18
-
Hi guys,
I moved a client onto PHP7 and had some issues with parts of Gantry 4 which I have solved. Is there somewhere to do a pull request?
The issue was with
body_contactform.php
/wp-content/themes/rt_gantry_wp/html/layouts
Line 75 needs to have preg_replace instead of eregi
Line 115 needs to remove /n/n
Hope that helps someone
Error was: Fatal error: Uncaught Error: Call to undefined function ereg_replace() PHP 7
The other error I can't remember but it was something about newline in header - Owner of Square Balloon
-
-
-
- MrT
- Preeminent Rocketeer
- Posts: 101084
- Thanks: 13484
- Web Designer/Developer
-
No, Gantry 4 is not on github - I will pass your comments on though.
Regards, Mark. - Please search forums before posting. Please make sure your post includes the version of the CMS you are using and a link to the problem. Annotations on screenshots can also be helpful to explain problems/goals. Please use the "secure" tab for confidential information.
-
-
-
- Eoin
- Hero Rocketeer
- Posts: 424
- Thanks: 18
-
There's actually more of an issue than I first thought.
I changed line 75 to this as preg_replace expects a third argument
} else if ( !preg_replace("/^[A-Z0-9._%-]+@[A-Z0-9._%-]+\.[A-Z]{2,4}$/", "", trim( $_POST['rt-contact-email'] ) ) ) {
WARNING. I'm barely a coder - Owner of Square Balloon
-
-
-
- MrT
- Preeminent Rocketeer
- Posts: 101084
- Thanks: 13484
- Web Designer/Developer
-
I've raised a ticket - our DEVS will check it all out in due course. There's even more to do because of PHP7.2 too.
Regards, Mark. -
The following users have thanked you: Eoin
- Please search forums before posting. Please make sure your post includes the version of the CMS you are using and a link to the problem. Annotations on screenshots can also be helpful to explain problems/goals. Please use the "secure" tab for confidential information.
-
-
-
- MrT
- Preeminent Rocketeer
- Posts: 101084
- Thanks: 13484
- Web Designer/Developer
-
This message contains only secure information that is visible to MrT, moderators and administrators
- Please search forums before posting. Please make sure your post includes the version of the CMS you are using and a link to the problem. Annotations on screenshots can also be helpful to explain problems/goals. Please use the "secure" tab for confidential information.
-
-
-
- MrT
- Preeminent Rocketeer
- Posts: 101084
- Thanks: 13484
- Web Designer/Developer
-
We have not set any end date as yet. The majority of our portfolio is still Gantry 4 based (although G5 templates are catching up now as we only do new template releases for Gantry 5).
So, at the moment, indefinitely, until we say otherwise.
Regards, Mark. - Please search forums before posting. Please make sure your post includes the version of the CMS you are using and a link to the problem. Annotations on screenshots can also be helpful to explain problems/goals. Please use the "secure" tab for confidential information.
-
-
-
- Eoin
- Hero Rocketeer
- Posts: 424
- Thanks: 18
-
Cheers for responding. By the way this is accidentally in the Joomla! forum not the WordPress one.
Even using an older version of PHP I'm not receiving contacts. I've replaced with a different form. - Owner of Square Balloon
-
-
-
- MrT
- Preeminent Rocketeer
- Posts: 101084
- Thanks: 13484
- Web Designer/Developer
-
moved topic for you.
Regards, Mark. - Please search forums before posting. Please make sure your post includes the version of the CMS you are using and a link to the problem. Annotations on screenshots can also be helpful to explain problems/goals. Please use the "secure" tab for confidential information.
-
-
-
- Kat05
- Preeminent Rocketeer
- Posts: 25898
- Thanks: 334
-
Hi there,
the corrected line 75 should look like this:
} else if ( !preg_match('|^[A-Z0-9._%-]+@[A-Z0-9._%-]+\.[A-Z]{2,4}$|i', trim( $_POST['rt-contact-email'] ) ) ) {
Will be included in the next Gantry 4 update release.
- Kat05 / QA Lead & Support / Germany
-
Time to create page: 0.077 seconds